From f6144f9634482d6bd0ed88a31495c6c6c88add96 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=81lvaro=20Cuesta?=
 <1827495+alvaro-cuesta@users.noreply.github.com>
Date: Thu, 2 Jan 2025 20:38:40 +0100
Subject: feat: sync with local plugin status in store (#733)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* fix: useDeckyState proper type and safety

* refactor: plugin list

Avoids unneeded re-renders. See https://react.dev/learn/you-might-not-need-an-effect#caching-expensive-calculations

* feat: sync with local plugin status in store

Adds some QoL changes to the plugin store browser:

- Add ✓ icon to currently installed plugin version in version selector
- Change install button label depending on the install type that the
  button would trigger
- Adds icon to install button for clarity

The goal is to make it clear to the user what the current state of the
installed plugin is, and what would be the impact of installing the
selected version.

Resolves #360

* lint: prettier

* fix: add missing translations

* refactor: safer translation strings on install

Prefer using `t(...)` instead of `TranslationHelper` since it ensures
that the translation keys are not missing in the locale files when
running the `extractext` task.

By adding comments with `t(...)` calls, `i18next-parser` will generate
the strings as if they were present as literals in the code (see
https://github.com/i18next/i18next-parser#caveats).

This does _not_ suppress the warnings (since `i18next-parser` does not
have access to TS types, so it cannot infer template literals) but it at
least makes it less likely that a translation will be missed by mistake,
have typos, etc.
---
 .../src/components/modals/PluginInstallModal.tsx   | 66 ++++++++++++++--------
 1 file changed, 41 insertions(+), 25 deletions(-)

(limited to 'frontend/src/components/modals/PluginInstallModal.tsx')

diff --git a/frontend/src/components/modals/PluginInstallModal.tsx b/frontend/src/components/modals/PluginInstallModal.tsx
index 227bd818..16419d91 100644
--- a/frontend/src/components/modals/PluginInstallModal.tsx
+++ b/frontend/src/components/modals/PluginInstallModal.tsx
@@ -2,13 +2,13 @@ import { ConfirmModal, Navigation, ProgressBarWithInfo, QuickAccessTab } from '@
 import { FC, useEffect, useState } from 'react';
 import { useTranslation } from 'react-i18next';
 
-import TranslationHelper, { TranslationClass } from '../../utils/TranslationHelper';
+import { InstallType, InstallTypeTranslationMapping } from '../../plugin';
 
 interface PluginInstallModalProps {
   artifact: string;
   version: string;
   hash: string;
-  installType: number;
+  installType: InstallType;
   onOK(): void;
   onCancel(): void;
   closeModal?(): void;
@@ -44,6 +44,8 @@ const PluginInstallModal: FC<PluginInstallModalProps> = ({
     };
   }, []);
 
+  const installTypeTranslationKey = InstallTypeTranslationMapping[installType];
+
   return (
     <ConfirmModal
       bOKDisabled={loading}
@@ -59,12 +61,15 @@ const PluginInstallModal: FC<PluginInstallModalProps> = ({
       }}
       strTitle={
         <div style={{ display: 'flex', flexDirection: 'row', alignItems: 'center', width: '100%' }}>
-          <TranslationHelper
-            transClass={TranslationClass.PLUGIN_INSTALL_MODAL}
-            transText="title"
-            i18nArgs={{ artifact: artifact }}
-            installType={installType}
-          />
+          {
+            // IMPORTANT! These comments are not cosmetic and are needed for `extracttext` task to work
+            // t('PluginInstallModal.install.title')
+            // t('PluginInstallModal.reinstall.title')
+            // t('PluginInstallModal.update.title')
+            // t('PluginInstallModal.downgrade.title')
+            // t('PluginInstallModal.overwrite.title')
+            t(`PluginInstallModal.${installTypeTranslationKey}.title`, { artifact: artifact })
+          }
           {loading && (
             <div style={{ marginLeft: 'auto' }}>
               <ProgressBarWithInfo
@@ -80,33 +85,44 @@ const PluginInstallModal: FC<PluginInstallModalProps> = ({
       strOKButtonText={
         loading ? (
           <div>
-            <TranslationHelper
-              transClass={TranslationClass.PLUGIN_INSTALL_MODAL}
-              transText="button_processing"
-              installType={installType}
-            />
+            {
+              // IMPORTANT! These comments are not cosmetic and are needed for `extracttext` task to work
+              // t('PluginInstallModal.install.button_processing')
+              // t('PluginInstallModal.reinstall.button_processing')
+              // t('PluginInstallModal.update.button_processing')
+              // t('PluginInstallModal.downgrade.button_processing')
+              // t('PluginInstallModal.overwrite.button_processing')
+              t(`PluginInstallModal.${installTypeTranslationKey}.button_processing`)
+            }
           </div>
         ) : (
           <div>
-            <TranslationHelper
-              transClass={TranslationClass.PLUGIN_INSTALL_MODAL}
-              transText="button_idle"
-              installType={installType}
-            />
+            {
+              // IMPORTANT! These comments are not cosmetic and are needed for `extracttext` task to work
+              // t('PluginInstallModal.install.button_idle')
+              // t('PluginInstallModal.reinstall.button_idle')
+              // t('PluginInstallModal.update.button_idle')
+              // t('PluginInstallModal.downgrade.button_idle')
+              // t('PluginInstallModal.overwrite.button_idle')
+              t(`PluginInstallModal.${installTypeTranslationKey}.button_idle`)
+            }
           </div>
         )
       }
     >
       <div>
-        <TranslationHelper
-          transClass={TranslationClass.PLUGIN_INSTALL_MODAL}
-          transText="desc"
-          i18nArgs={{
+        {
+          // IMPORTANT! These comments are not cosmetic and are needed for `extracttext` task to work
+          // t('PluginInstallModal.install.desc')
+          // t('PluginInstallModal.reinstall.desc')
+          // t('PluginInstallModal.update.desc')
+          // t('PluginInstallModal.downgrade.desc')
+          // t('PluginInstallModal.overwrite.desc')
+          t(`PluginInstallModal.${installTypeTranslationKey}.desc`, {
             artifact: artifact,
             version: version,
-          }}
-          installType={installType}
-        />
+          })
+        }
       </div>
       {hash == 'False' && <span style={{ color: 'red' }}>{t('PluginInstallModal.no_hash')}</span>}
     </ConfirmModal>
-- 
cgit v1.2.3

